-
-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smuxi: init at unstable-2023-07-01 #249831
Conversation
@GrahamcOfBorg eval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing gnome2.pango
with pango
makes nix-review happy on my end, but not sure if this is the right way to go?
pkgs/applications/networking/instant-messengers/smuxi/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/smuxi/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/smuxi/default.nix
Outdated
Show resolved
Hide resolved
388b0d2
to
1003257
Compare
@stigtsp looks good to me, it builds and works, so I committed and pushed the change |
Could you amend it into the |
I could squash the commit but then the issue and solution won't be able to other people who may also run into it. |
I have resolved the maintainer-list.nix conflict |
Squashed and rebased, should be good as is to be merged @stigtsp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Smuxi was [merged][GitHub-PR] into nixpkgs and is now available via the unstable channel. GitHub-PR: NixOS/nixpkgs#249831
Smuxi was [merged][GitHub-PR] into nixpkgs and is now available via the unstable channel. GitHub-PR: NixOS/nixpkgs#249831
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)