Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smuxi: init at unstable-2023-07-01 #249831

Merged
merged 3 commits into from
Mar 27, 2024
Merged

smuxi: init at unstable-2023-07-01 #249831

merged 3 commits into from
Mar 27, 2024

Conversation

meebey
Copy link
Contributor

@meebey meebey commented Aug 17, 2023

Description of changes

  • Adding Smuxi that I am also the author of.
  • GTK# is a dependency and was restricted to Linux even though it builds and works fine on Darwin so I adjusted the platform line for it.
  • Added myself as maintainer.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@stigtsp
Copy link
Member

stigtsp commented Aug 17, 2023

@GrahamcOfBorg eval

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing gnome2.pango with pango makes nix-review happy on my end, but not sure if this is the right way to go?

@meebey
Copy link
Contributor Author

meebey commented Aug 22, 2023

Replacing gnome2.pango with pango makes nix-review happy on my end, but not sure if this is the right way to go?

@stigtsp looks good to me, it builds and works, so I committed and pushed the change

@stigtsp
Copy link
Member

stigtsp commented Aug 22, 2023

Replacing gnome2.pango with pango makes nix-review happy on my end, but not sure if this is the right way to go?

@stigtsp looks good to me, it builds and works, so I committed and pushed the change

Could you amend it into the smuxi: init at unstable-2023-07-01 commit?

@meebey
Copy link
Contributor Author

meebey commented Aug 22, 2023

Replacing gnome2.pango with pango makes nix-review happy on my end, but not sure if this is the right way to go?

@stigtsp looks good to me, it builds and works, so I committed and pushed the change

Could you amend it into the smuxi: init at unstable-2023-07-01 commit?

I could squash the commit but then the issue and solution won't be able to other people who may also run into it.

@meebey
Copy link
Contributor Author

meebey commented Mar 14, 2024

I have resolved the maintainer-list.nix conflict

@meebey
Copy link
Contributor Author

meebey commented Mar 27, 2024

Squashed and rebased, should be good as is to be merged @stigtsp

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stigtsp stigtsp merged commit 647a569 into NixOS:master Mar 27, 2024
25 of 26 checks passed
meebey added a commit to meebey/smuxi-web that referenced this pull request Mar 28, 2024
Smuxi was [merged][GitHub-PR] into nixpkgs and is now available via the unstable channel.

  GitHub-PR: NixOS/nixpkgs#249831
meebey added a commit to meebey/smuxi-web that referenced this pull request Mar 28, 2024
Smuxi was [merged][GitHub-PR] into nixpkgs and is now available via the unstable channel.

  GitHub-PR: NixOS/nixpkgs#249831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants