Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configurable-http-proxy: use buildNpmPackage #250203

Merged
merged 1 commit into from
Aug 21, 2023
Merged

configurable-http-proxy: use buildNpmPackage #250203

merged 1 commit into from
Aug 21, 2023

Conversation

dotlambda
Copy link
Member

Description of changes

See #229475

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @ixxie who originally packaged it in #31871

GaetanLepage
GaetanLepage approved these changes Aug 19, 2023
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM !

@dotlambda dotlambda force-pushed the configurable-http-proxy-buildNpmPackage branch from 4bce221 to 936d4b5 Compare August 20, 2023 20:57
@natsukium
Copy link
Member

Result of nixpkgs-review pr 250203 run on x86_64-linux 1

29 packages built:
  • configurable-http-proxy
  • python310Packages.batchspawner
  • python310Packages.batchspawner.dist
  • python310Packages.dockerspawner
  • python310Packages.dockerspawner.dist
  • python310Packages.jupyterhub
  • python310Packages.jupyterhub-ldapauthenticator
  • python310Packages.jupyterhub-ldapauthenticator.dist
  • python310Packages.jupyterhub-systemdspawner
  • python310Packages.jupyterhub-systemdspawner.dist
  • python310Packages.jupyterhub-tmpauthenticator
  • python310Packages.jupyterhub-tmpauthenticator.dist
  • python310Packages.jupyterhub.dist
  • python310Packages.oauthenticator
  • python310Packages.oauthenticator.dist
  • python311Packages.batchspawner
  • python311Packages.batchspawner.dist
  • python311Packages.dockerspawner
  • python311Packages.dockerspawner.dist
  • python311Packages.jupyterhub
  • python311Packages.jupyterhub-ldapauthenticator
  • python311Packages.jupyterhub-ldapauthenticator.dist
  • python311Packages.jupyterhub-systemdspawner
  • python311Packages.jupyterhub-systemdspawner.dist
  • python311Packages.jupyterhub-tmpauthenticator
  • python311Packages.jupyterhub-tmpauthenticator.dist
  • python311Packages.jupyterhub.dist
  • python311Packages.oauthenticator
  • python311Packages.oauthenticator.dist

natsukium
natsukium approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@natsukium natsukium merged commit 5041a0e into NixOS:master Aug 21, 2023
20 of 21 checks passed
@dotlambda dotlambda deleted the configurable-http-proxy-buildNpmPackage branch August 21, 2023 01:45
@natsukium natsukium mentioned this pull request Aug 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
6.topic: nodejs 6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @natsukium @GaetanLepage