Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viennarna: rename from ViennaRNA #250922

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Conversation

natsukium
Copy link
Member

Description of changes

related to #245383

In the work, I found that we can update it, and the source code is uploaded to the VCS.
I'd like to get the source from GitHub for future updates, but some changes seem to be needed.
Therefore, I'd like to ask the maintainer's opinion before updating the source.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium
Copy link
Member Author

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • viennarna (python310Packages.viennarna)

@prusnak
Copy link
Member

prusnak commented Aug 23, 2023

I'd like to get the source from GitHub for future updates

What's the advantage of using the source from GitHub rather than downloading a tarball from univie.ac.at?

@natsukium
Copy link
Member Author

We will receive notifications of version updates and can update automatically.
It would also make it easier to keep track of differences.

@prusnak
Copy link
Member

prusnak commented Aug 23, 2023

can update automatically.

OK, that sounds good. If you want to rework the source fetching, feel free to do so. But in that case, please remove me as a maintainer and yourself as one. Thanks!

@natsukium natsukium merged commit acc0ac9 into NixOS:master Sep 13, 2023
25 checks passed
@natsukium natsukium deleted the viennarna/update branch September 13, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants