apptainer, singularity: use self-contained LOCALSTATEDIR by default #250949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leave only the SESSIONDIR, which is "$LOCALSTATEDIR/$projectName/mnt/session"
Use "$out/var/lib" as LOCALSTATEDIR configuration value by default intsead of "/var/lib" as a way toward top-level-directory independent runtime. Add input argument externalLocalStateDir to optionally specify the path to external LOCALSTATEDIR if not null. Add NixOS module option programs.singularity.enableExternalLocalStateDir (default to true) to use "/var/lib" as LOCALSTATEDIR.
ShamrockLee
force-pushed
the
apptainer-localstatedir
branch
from
7c24f11
to
ac77669
Compare
ShamrockLee
changed the title
13 tasks
nobodyinperson
approved these changes
Nov 14, 2023
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
"$out/var/lib"for theLOCALSTATEDIRconfiguration option instead of the top-level"/var/lib". This change impacts theSESSIONDIR(container-run-time mount point) configuration, which is set to$LOCALSTATEDIR/<apptainer or singularity>/mnt/session. This detaches the packages from the top-level directory, rendering the NixOS module optional.LOCALSTATEDIRif notnull.programs.singularity.enableExternalSysConfDirto specify whether to set the top-level "/var/lib" asLOCALSTATEDIRor not. Default it to true to keep the default behavior ofprograms.singularityunchanged.LOCALSTATEDIR, leaving only theSESSIONDIR.Fixes #250581
Cc: @nobodyinperson, @jbedo
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)