Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quodlibet: 4.5.0 -> 4.6.0 #250955

Merged
merged 2 commits into from
Sep 6, 2023
Merged

quodlibet: 4.5.0 -> 4.6.0 #250955

merged 2 commits into from
Sep 6, 2023

Conversation

paveloom
Copy link
Member

Description of changes

https://github.com/quodlibet/quodlibet/releases/tag/release-4.6.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@paveloom paveloom changed the title Quodlibet quodlibet: 4.5.0 -> 4.6.0 Aug 23, 2023
@ofborg ofborg bot requested a review from pbogdan August 23, 2023 11:46
Copy link
Contributor

@999eagle 999eagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 250955 run on x86_64-linux 1

15 packages built:
  • quodlibet
  • quodlibet-full
  • quodlibet-full.dist
  • quodlibet-full.doc
  • quodlibet-without-gst-plugins
  • quodlibet-without-gst-plugins.dist
  • quodlibet-without-gst-plugins.doc
  • quodlibet-xine
  • quodlibet-xine-full
  • quodlibet-xine-full.dist
  • quodlibet-xine-full.doc
  • quodlibet-xine.dist
  • quodlibet-xine.doc
  • quodlibet.dist
  • quodlibet.doc

I've tested basic functionality of quodlibet. Looks good to me apart from the two small nitpicks.

pkgs/applications/audio/quodlibet/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/quodlibet/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@999eagle 999eagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank
Copy link
Member

wegank commented Sep 6, 2023

@ofborg build quodlibet quodlibet.passthru.tests

@paveloom
Copy link
Member Author

paveloom commented Sep 6, 2023

Brought back the --deselect=tests/test_po.py::TPOTFILESIN::test_missing bit, should fix the build failure on x86_64-linux.

@wegank wegank merged commit 4194820 into NixOS:master Sep 6, 2023
22 checks passed
@paveloom paveloom deleted the quodlibet branch September 6, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants