Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass: stop installing password-store.el #251293

Merged
merged 1 commit into from
Aug 25, 2023
Merged

pass: stop installing password-store.el #251293

merged 1 commit into from
Aug 25, 2023

Conversation

jian-lin
Copy link
Contributor

password-store.el is on MELPA so it is available in Nixpkgs as emacs.pkgs.password-store.

Using emacs.pkgs.password-store is preferred because of better package quality:

  • Emacs lisp package dependencies are automatically installed
  • byte-compilation is done
  • native-compilation is done

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

password-store.el is on MELPA so it is available in Nixpkgs as
emacs.pkgs.password-store.

Using emacs.pkgs.password-store is preferred because of better package
quality:
- Emacs lisp package dependencies are automatically installed
- byte-compilation is done
- native-compilation is done
@Ma27 Ma27 merged commit c4494e2 into NixOS:master Aug 25, 2023
24 checks passed
@jian-lin jian-lin deleted the fix-pass branch August 25, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants