Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtv: 1.14.1 -> 1.15.1 #25207

Merged
merged 11 commits into from Apr 27, 2017
Merged

rtv: 1.14.1 -> 1.15.1 #25207

merged 11 commits into from Apr 27, 2017

Conversation

matthiasbeyer
Copy link
Contributor

@matthiasbeyer matthiasbeyer commented Apr 25, 2017

Motivation for this change

Update rtv

As rtv introduces a new dependency, I package this dependency here. This does not yet work - I don't know why, though. Help from some pythonist would be awesome!

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@matthiasbeyer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh, @jgeerds and @nocoolnametom to be potential reviewers.

@@ -10227,6 +10227,32 @@ in {
};
};


vcrpy = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new packages to python-modules and only reference them here.

};

buildInputs = with pythonPackages; [
vcrpy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add it to propagatedBuildInputs instead.

@matthiasbeyer
Copy link
Contributor Author

hm. I fixed what you told me (pushing in a few sec), but it still fails:

running install tests
running test
Searching for pytest-httpbin
Reading https://pypi.python.org/simple/pytest-httpbin/
Download error on https://pypi.python.org/simple/pytest-httpbin/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'pytest-httpbin' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.python.org/simple/
Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for pytest-httpbin
error: Could not find suitable distribution for Requirement.parse('pytest-httpbin')
builder for ‘/nix/store/y79m6lxf9gcb5cnrj96mpjmjs084a9c0-python2.7-vcrpy-1.10.5.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/r184lp74si70fnj7anybl0fpq7q35mq3-rtv-1.15.1.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/r184lp74si70fnj7anybl0fpq7q35mq3-rtv-1.15.1.drv’ failed

@Mic92
Copy link
Member

Mic92 commented Apr 26, 2017

you need to add the package pytest-httpbin.

@matthiasbeyer
Copy link
Contributor Author

Builds and works for me now.

propagatedBuildInputs = [];

# Tests in neither the archive nor the repo
doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not true.


meta = {
description = "py.test plugin to store test expectations and mark tests based on them";
homepage = https://github.com/gsnedders/pytest-expect;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong copy'n'paste

@Mic92 Mic92 merged commit a89a091 into NixOS:master Apr 27, 2017
@Mic92
Copy link
Member

Mic92 commented Apr 27, 2017

Please check your templates next time for python packages more carefully, when creating new packages.

@matthiasbeyer matthiasbeyer deleted the update-rtv branch April 27, 2017 11:14
@matthiasbeyer
Copy link
Contributor Author

Thanks for cleaning it up! Will do better next time!

@sifmelcara
Copy link
Member

Hello, rtv 1.15.1 is broken on the latest unstable for me, it says

$ nix-shell -p rtv
error: multidict-2.1.4 not supported for interpreter python2.7
(use ‘--show-trace’ to show detailed location information)

Maybe related to changes done in this pr?

@FRidh
Copy link
Member

FRidh commented Apr 30, 2017

here's the trace:

$ nix-build -A rtv --show-trace
error: while evaluating the attribute ‘buildInputs’ of the derivation ‘rtv-1.15.1’ at /home/freddy/Code/libraries/nixpkgs/pkgs/development/interpreters/python/mk-python-derivation.nix:56:3:
while evaluating the attribute ‘buildInputs’ of the derivation ‘python2.7-vcrpy-1.10.5’ at /home/freddy/Code/libraries/nixpkgs/pkgs/development/interpreters/python/mk-python-derivation.nix:56:3:
while evaluating the attribute ‘propagatedBuildInputs’ of the derivation ‘python2.7-yarl-0.8.1’ at /home/freddy/Code/libraries/nixpkgs/pkgs/development/interpreters/python/mk-python-derivation.nix:56:3:
while evaluating ‘getOutput’ at /home/freddy/Code/libraries/nixpkgs/lib/attrsets.nix:450:23, called from undefined position:
while evaluating ‘getCrossDrv’ at /home/freddy/Code/libraries/nixpkgs/pkgs/stdenv/generic/default.nix:135:21, called from undefined position:
while evaluating ‘callPackageWith’ at /home/freddy/Code/libraries/nixpkgs/lib/customisation.nix:95:35, called from /home/freddy/Code/libraries/nixpkgs/pkgs/top-level/python-packages.nix:14485:15:
while evaluating ‘makeOverridable’ at /home/freddy/Code/libraries/nixpkgs/lib/customisation.nix:54:24, called from /home/freddy/Code/libraries/nixpkgs/lib/customisation.nix:99:8:
while evaluating anonymous function at /home/freddy/Code/libraries/nixpkgs/pkgs/development/python-modules/multidict/default.nix:1:1, called from /home/freddy/Code/libraries/nixpkgs/lib/customisation.nix:56:12:
while evaluating ‘makeOverridable’ at /home/freddy/Code/libraries/nixpkgs/lib/customisation.nix:54:24, called from /home/freddy/Code/libraries/nixpkgs/pkgs/development/python-modules/multidict/default.nix:11:4:
while evaluating anonymous function at /home/freddy/Code/libraries/nixpkgs/pkgs/development/interpreters/python/build-python-package.nix:20:1, called from /home/freddy/Code/libraries/nixpkgs/lib/customisation.nix:56:12:
while evaluating ‘makeOverridable’ at /home/freddy/Code/libraries/nixpkgs/lib/customisation.nix:54:24, called from /home/freddy/Code/libraries/nixpkgs/pkgs/development/interpreters/python/build-python-package.nix:37:4:
while evaluating anonymous function at /home/freddy/Code/libraries/nixpkgs/pkgs/development/interpreters/python/mk-python-derivation.nix:11:1, called from /home/freddy/Code/libraries/nixpkgs/lib/customisation.nix:56:12:
multidict-2.1.4 not supported for interpreter python2.7

Might want to consider using python3 for this package anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants