New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rtv: 1.14.1 -> 1.15.1 #25207
rtv: 1.14.1 -> 1.15.1 #25207
Conversation
@matthiasbeyer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh, @jgeerds and @nocoolnametom to be potential reviewers. |
pkgs/top-level/python-packages.nix
Outdated
@@ -10227,6 +10227,32 @@ in { | |||
}; | |||
}; | |||
|
|||
|
|||
vcrpy = buildPythonPackage rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add new packages to python-modules
and only reference them here.
}; | ||
|
||
buildInputs = with pythonPackages; [ | ||
vcrpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add it to propagatedBuildInputs
instead.
hm. I fixed what you told me (pushing in a few sec), but it still fails:
|
you need to add the package |
d8e562b
to
7213b3b
Compare
Builds and works for me now. |
propagatedBuildInputs = []; | ||
|
||
# Tests in neither the archive nor the repo | ||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not true.
|
||
meta = { | ||
description = "py.test plugin to store test expectations and mark tests based on them"; | ||
homepage = https://github.com/gsnedders/pytest-expect; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong copy'n'paste
Please check your templates next time for python packages more carefully, when creating new packages. |
Thanks for cleaning it up! Will do better next time! |
Hello, rtv 1.15.1 is broken on the latest unstable for me, it says
Maybe related to changes done in this pr? |
here's the trace:
Might want to consider using |
Motivation for this change
Update
rtv
As rtv introduces a new dependency, I package this dependency here. This does not yet work - I don't know why, though. Help from some pythonist would be awesome!
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)