tmuxPlugins.t-smart-tmux-session-manager: init at 2.8.0

[hmajid2301]

Description of changes

A tmux plugin for making session management a lot easier, using zoxide and fzf. https://github.com/joshmedeski/t-smart-tmux-session-manager

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2835

[bbigras]

Did you see that there are versions (like v2.6.0) on https://github.com/joshmedeski/t-smart-tmux-session-manager/releases ?

[hmajid2301]

i did not 😓, let me fix that :)

[bbigras]

Builds and runs fine, thanks!

[hmajid2301]

Thank you very much for your review!

[bbigras]

Do you use the t command when not in tmux?

Something like:

postInstall = ''
  mv $target/bin $out/
'';

It seems other tmux plugins replace fzf and other bins with their full path (in case people don't have them installed). Not all plugins have them though.

maybe something like:

# for the t shell script
wrapProgram $out/bin/t \
        --prefix PATH : ${with pkgs; lib.makeBinPath (
        [ pkgs.fzf pkgs.zoxide ... ]
        )}

# for tmux files
find $target -type f -print0 | xargs -0 sed -i -e 's|fzf |${pkgs.fzf}/bin/fzf |g'
# ...

[bbigras]

unless maybe the plugin doesn't use zoxide if it's not in PATH.

[hmajid2301]

Do you use the t command when not in tmux?

Yes, outside of tmux it creates a new session (or loads one if it exists)

unless maybe the plugin doesn't use zoxide if it's not in PATH.

I think it needs zoxide and fzf as deps, actually. Will update as
suggested above 🤔!

[hmajid2301]

Do we also need to replace zoxide like we did for fzf ?

[bbigras]

Yes, outside of tmux it creates a new session (or loads one if it exists)

Do you use tmux with home-manager? I think adding t-smart-tmux-session-manager to programs.tmux.plugins didn't add t to my path.

[hmajid2301]

I had it setup slightly different:

  t-smart-manager = pkgs.tmuxPlugins.mkTmuxPlugin {
    pluginName = "t-smart-tmux-session-manager";
    version = "unstable-2023-09-20";
    rtpFilePath = "t-smart-tmux-session-manager.tmux";
    src = pkgs.fetchFromGitHub {
      owner = "joshmedeski";
      repo = "t-smart-tmux-session-manager";
      rev = "63360755451a1d536f5847b3a3dc41bb3050b10c";
      sha256 = "00051slyy55qdxf0l41kfw6sr46nm2br31hdkwpy879ia5acligi";
    };
  };

and then:

    programs.fish.shellInit = ''
      fish_add_path ${t-smart-manager}/share/tmux-plugins/t-smart-tmux-session-manager/bin/
    '';

Which is a bit of hack tbh thinking about it.

[hmajid2301]

Do you use tmux with home-manager? I think adding t-smart-tmux-session-manager to programs.tmux.plugins didn't add t to my path.

hmm interesting 🤔

[bbigras]

Can you use the tag of the latest version? Like

nixpkgs/pkgs/misc/tmux-plugins/default.nix

Lines 460 to 472 in e59598b

	plumb = mkTmuxPlugin rec {
	pluginName = "plumb";
	version = "0.1.1";
	src = fetchFromGitHub {
	owner = "eraserhd";
	repo = "tmux-plumb";
	rev = "v${version}";
	sha256 = "1c6k4fdl0az9811r6k164mgd4w5la75xr6x7nabmy046xc0z5i2r";
	};
	postInstall = ''
	sed -i -e 's,9 plumb,${pkgs.plan9port}/bin/9 plumb,' $target/scripts/plumb
	'';
	};

[hmajid2301]

i made some changes is this whay you meant!

[bbigras]

I think so. Thanks.

Do you have hangs with 2.8.0? On my computer it seems to hang when I use ctrl+b + T

[hmajid2301]

nope works fine for me!

[bbigras]

Can you squash your commits please? Don't forget to replace "init at unstable-2023-06-05" with the right version.

[hmajid2301]

done

[bbigras]

Thank you very much for the PR. I have been using this plugin every day since I discovered it.