nodePackages.three: drop #252430
Merged
nodePackages.three: drop #252430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
reviewed
Aug 31, 2023
| description = "General purpose JavaScript 3D library"; | ||
| homepage = "https://threejs.org"; | ||
| license = licenses.mit; | ||
| maintainers = with maintainers; [ timokau ]; |
There was a problem hiding this comment.
Can you give a reference for this?
There was a problem hiding this comment.
Instead of me this should probably be the sage team (i.e., mostly @collares and @omasanori nowadays) since I added this for sage. I agree however that it is better to remove it since sage doesn't need it anymore.
|
I'd rather just remove |
|
This was originally added for sage, but that now uses threejs-sage. So yes, this probably can be removed. |
Lord-Valen
force-pushed
the
npm-threejs
branch
from
f4e3aac
to
5d79525
Compare
Let's do so. |
Lord-Valen
force-pushed
the
npm-threejs
branch
from
5d79525
to
25afdf7
Compare
Lord-Valen
changed the title
Lord-Valen
force-pushed
the
npm-threejs
branch
from
25afdf7
to
d7a3698
Compare
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
10.rebuild-linux: 1
10.rebuild-linux: 1-10
labels
happysalada
pushed a commit
to happysalada/nixpkgs
that referenced
this pull request
Sep 9, 2023
This was originally added for sage, but that now uses threejs-sage, three can be removed. see NixOS#252430
ivandimitrov8080
pushed a commit
to ivandimitrov8080/nixpkgs
that referenced
this pull request
Sep 10, 2023
This was originally added for sage, but that now uses threejs-sage, three can be removed. see NixOS#252430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
See #229475.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)