php: add optional phpSrc attribute

[drupol]

This will allow building PHP from source, without using .overrideAttrs(), if the new attribute phpSrc is not set, the default behavior (fetchurl) is used.

Example:

{ callPackage, fetchFromGitHub, ... }:

php = callPackage ./generic.nix ({
  version = "8.1.13";
  phpSrc = fetchFromGitHub {
    owner = "php";
    repo = "php-src";
    rev = "php-8.1.13";
    hash = "sha256-n2SCCnMrSxVnIJrpqMJ7NLydAuSlnb/X5nULtKb03uI=";
  };
});

This PR is a refresh of the following PR: #155012

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[jtojnar]

How is this change relevant?

[drupol]

This is mandatory when building PHP from source. I haven't found a better way to do this, do you have a better idea?
When PHP release maintainers are doing a distribution, they run the script makedist that download that file using wget.

[jtojnar]

This will allow building PHP from source, without using .overrideAttrs()

Please also include motivation in the commit message, this is just an end point.

[drupol]

This will allow building PHP from source, without using .overrideAttrs()

Please also include motivation in the commit message, this is just an end point.

It's done already, should I add something else ?

[jtojnar]

It's done already, should I add something else ?

I only see overrideAttrs mentioned but without an explanation why it is not desirable.

[drupol]

Done.