-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libsForQt5.qt5.qtimageformats
: add dependencies jasper
, libmng
, and libwebp
#255044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you follow the commit message (and PR title) guidelines at https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions ?
Oh, didn't see those, sorry Will do |
libsForQt5.qt5.qtimageformats
: add dependencies jasper
, libmng
, and libwebp
I don't think this will make webp available for you, as before this PR the log says
|
However, it would probably help with #254798 right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log looks good, indicating unvendoring of libwebp (a security fix ATM). This PR is exactly what we do in the qt6 version already, too. I built several reverse dependencies on x86_64 NixOS.
(squashed in order to improve the commit message) |
Yeah, I actually copy-pasted this from QT6 lol |
Aren't reverse dependencies called "dependents"? |
Maybe, I don't care about terminology too much here, as long as the meaning is clear. |
Can the libwebp part at least get cherry-picked to 23.05 for CVE-2023-4863 remediation? EDIT: oops, I missed #255432 - thanks for being ahead of me :p |
Description of changes
These dependencies are on both qt6-imageformats (in this repo) and the
qt5-imageformats
Arch Linux package. I noticed a lack of WEBP support in Spectacle, and this will probably fix it.I haven't tested on my own machine, because I don't have the time right now to recompile a bunch of packages.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)