Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal-desktop: 6.30.1 -> 6.30.2 #255129

Merged
merged 1 commit into from
Sep 14, 2023
Merged

signal-desktop: 6.30.1 -> 6.30.2 #255129

merged 1 commit into from
Sep 14, 2023

Conversation

cmovcc
Copy link
Contributor

@cmovcc cmovcc commented Sep 14, 2023

Description of changes

signal-desktop: 6.30.1 -> 6.30.2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This version of signal-desktop contains "the latest version of the Electron v25 stable branch that was just published with a fix for [the WebP bug] in Chrome", see signalapp/Signal-Desktop#6603 (comment). I did not test the signal-desktop-beta latest version yet.

@cmovcc
Copy link
Contributor Author

cmovcc commented Sep 14, 2023

I guess it is worth referencing the WebP CVE (CVE-2023-4863) tracking: #254798.

@delroth
Copy link
Contributor

delroth commented Sep 14, 2023

@ofborg build signal-desktop

Copy link
Contributor

@delroth delroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM, I'll merge if ofborg is happy.

@delroth delroth merged commit bf2cf5a into NixOS:master Sep 14, 2023
24 of 27 checks passed
@github-actions
Copy link
Contributor

Backport failed for release-23.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-23.05
git worktree add -d .worktree/backport-255129-to-release-23.05 origin/release-23.05
cd .worktree/backport-255129-to-release-23.05
git checkout -b backport-255129-to-release-23.05
ancref=$(git merge-base c8430909172201d1e24688aeef57d5de624e196d e24efaf742a1db68433706396ae6b8ecf642a3a9)
git cherry-pick -x $ancref..e24efaf742a1db68433706396ae6b8ecf642a3a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants