Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.xdot: 1.2 -> 1.3 #255254

Merged
merged 1 commit into from
Oct 6, 2023
Merged

python3.pkgs.xdot: 1.2 -> 1.3 #255254

merged 1 commit into from
Oct 6, 2023

Conversation

doronbehar
Copy link
Contributor

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar mentioned this pull request Sep 15, 2023
Open
13 tasks
@doronbehar
Copy link
Contributor Author

I prevented another double wrapping. Tested it again, and it seems functional. Will merge when CI is green.

@kilianar
Copy link
Contributor

kilianar commented Oct 6, 2023

The changes look good to me, and I can confirm that the application runs fine on a simple example graph.

@doronbehar
python3.pkgs.xdot: 1.2 -> 1.3
2f244e3 
Numerous other fixes / improvements:
- Format expression with 1 line per argument and input
- Use fetchFromGitHub to fetch the `test.py` file not distributed with
  the pypi source.
- Enable tests.
- Prevent double wrapping by setting makeWrapperArgs instead of using
  wrapProgram.
- Run check hooks.
@doronbehar
Copy link
Contributor Author

Thanks for the review :).

@doronbehar doronbehar merged commit da31701 into NixOS:master Oct 6, 2023
18 checks passed
@doronbehar doronbehar deleted the pkg/python-xdot branch October 6, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilianar kilianar kilianar left review comments

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @kilianar