Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyperlink: init at 0.1.31 #255416

Merged
merged 2 commits into from
Sep 17, 2023
Merged

hyperlink: init at 0.1.31 #255416

merged 2 commits into from
Sep 17, 2023

Conversation

rossabaker
Copy link
Contributor

@rossabaker rossabaker commented Sep 16, 2023

Description of changes

Hyperlink is a very fast link checker for CI.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/tools/hyperlink/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/hyperlink/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/hyperlink/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/hyperlink/default.nix Outdated Show resolved Hide resolved
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after removing the changes to all-packages.nix. 2 commits would be ideal, one for the maintainer and one for the package.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@rossabaker
Copy link
Contributor Author

Thanks for the reviews! Squashed down to two commits.

Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

@fabianhjr
Copy link
Member

Result of nixpkgs-review pr 255416 run on x86_64-linux 1

1 package built:
  • hyperlink

@fabianhjr fabianhjr merged commit 948e875 into NixOS:master Sep 17, 2023
26 checks passed
@rossabaker rossabaker deleted the hyperlink branch September 18, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants