Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.msprime: use pytestCheckHook #255471

Merged
merged 1 commit into from
Sep 16, 2023
Merged

python3.pkgs.msprime: use pytestCheckHook #255471

merged 1 commit into from
Sep 16, 2023
+19 −23

Conversation

doronbehar
Copy link
Contributor

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@doronbehar
python3.pkgs.msprime: use pytestCheckHook
942d048 
Instead of manually specifying the disabled tests and test paths in
`checkPhase`, use the pytestCheckHook for that, and avoid the issue
described at NixOS#255262 by removing
the source directory.
@doronbehar doronbehar mentioned this pull request Sep 16, 2023
Open
13 tasks
alxsimon
alxsimon approved these changes Sep 16, 2023
View reviewed changes
Copy link
Contributor

@alxsimon alxsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and built locally
Thanks for tracking down the issue

@doronbehar
Copy link
Contributor Author

@ofborg build python3.pkgs.msprime

@doronbehar doronbehar merged commit 23edd7b into NixOS:master Sep 16, 2023
26 checks passed
@doronbehar doronbehar deleted the pkg/python-msprime branch September 16, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxsimon alxsimon alxsimon approved these changes

@Janik-Haag Janik-Haag Awaiting requested review from Janik-Haag

@natsukium natsukium Awaiting requested review from natsukium

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @alxsimon @delroth