Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

environment: remove sbin from PATH #25550

Merged
merged 1 commit into from May 9, 2017
Merged

environment: remove sbin from PATH #25550

merged 1 commit into from May 9, 2017

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented May 6, 2017

sbin is a symlink to bin. /run/current-system/sw/sbin and related
profiles only contains packages, which have this symlink. It is a subset
of bin.

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

sbin is a symlink to bin. /run/current-system/sw/sbin and related
profiles only contains packages, which have this symlink. It is a subset
of bin.
@mention-bot
Copy link

@Mic92, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nbp, @oxij and @edolstra to be potential reviewers.

@matthewbauer
Copy link
Member

Side note but for non-NixOS, /sbin still gets in PATH:

https://github.com/NixOS/nix/blob/master/scripts/nix-profile.sh.in#L88

Mic92 added a commit to Mic92/nix-1 that referenced this pull request May 7, 2017
sbin is a symlink to bin. 
profiles only contains packages, which have this symlink. 
It is a subset of bin.

related to NixOS/nixpkgs#25550
@Mic92 Mic92 merged commit 33cfad8 into NixOS:master May 9, 2017
@Mic92 Mic92 deleted the sbin branch May 9, 2017 07:39
Mic92 added a commit that referenced this pull request May 9, 2017
Mic92 added a commit that referenced this pull request May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants