Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytestCheckHook: proof of concept of a solution to recursive imports in some modules #255530

Closed
wants to merge 2 commits into from

Conversation

lucasew
Copy link
Contributor

@lucasew lucasew commented Sep 16, 2023

Description of changes

Related #255262

Proposed solution for the issue that python -m pytest adds the current directory to sys.path and mess stuff up.

I wanted to test with more significant packages such as Orange3 and rg -l cython $(rg -l pytestCheckHook)

I was also trying to write a proof of concept python module to reproduce the issue but it seems that Cython was tricky to be imported that I linked to that issue

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

…ypoints to solve circular imports with native extensions

Signed-off-by: lucasew <lucas59356@gmail.com>
Signed-off-by: lucasew <lucas59356@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant