python3.pkgs.scipy: use pytestCheckHook && python3.pkgs.numpy: small cleanup #255607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
doronbehar
force-pushed
the
pkg/numpy-scipy-pytest
branch
from
a2510ea
to
970167f
Compare
14 tasks
doronbehar
force-pushed
the
pkg/numpy-scipy-pytest
branch
from
970167f
to
7230254
Compare
|
I built scipy locally, and tests seem to take long, but I'm not sure. Having another eye on this would be nice. |
doronbehar
changed the title
doronbehar
force-pushed
the
pkg/numpy-scipy-pytest
branch
from
7230254
to
e0d075c
Compare
| @@ -102,10 +103,14 @@ in buildPythonPackage rec { | |||
|
|
|||
| nativeCheckInputs = [ | |||
| pytestCheckHook | |||
| # Parallelises tests a bit | |||
There was a problem hiding this comment.
Suggested change
| # Parallelises tests a bit |
Related to: NixOS#255262 and a follow-up to NixOS#251923 : - The NOSE_EXCLUDE environment variable was removed due to being unneeded, as upstream uses pytest for a long time now, and that disabled test was removed since. - Support parallel testing with pytest-xdist
doronbehar
force-pushed
the
pkg/numpy-scipy-pytest
branch
from
e0d075c
to
4936fd3
Compare
Related to: NixOS#255262 . This allows Using the hook's builtin support for of `disabledTests` and `disabledTestPaths`.
doronbehar
force-pushed
the
pkg/numpy-scipy-pytest
branch
from
4936fd3
to
f2eddda
Compare
|
I'm closing, as this seems fixed scipy's 1.12.0rc2 . I'll open a new PR with other updates as well when the time comes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #255262 .
Haven't tested this change yet., will undraft this when it is tested.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)