Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ghcjs as fixed #25624

Merged
merged 1 commit into from
May 9, 2017
Merged

Mark ghcjs as fixed #25624

merged 1 commit into from
May 9, 2017

Conversation

dmjio
Copy link
Member

@dmjio dmjio commented May 8, 2017

Motivation for this change

GHCJS seems to be already be fixed, but not marked as unbroken. I plan on playing with it, so would like to be notified of further broken notifications (hence why I've added myself to the maintainers list)

cc @cstrahan @jwiegley

Original error: http://hydra.nixos.org/build/45110274

λ nixos ~ → nix-build '<nixpkgs>' -A haskell.compiler.ghcjs 
/nix/store/gp9zkvzs36kbzfrziqka82a2iik8cw0y-ghcjs-0.2.0

This was built off a hash close to master. The original error seems to be related to a broken test dependency of a boot library.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@dmjio, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Profpatsch, @3noch and @cstrahan to be potential reviewers.

Copy link
Member

@pSub pSub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you rename your commit so that it adheres to the guidelines. Like ghcjs: mark as fixed.

@dmjio
Copy link
Member Author

dmjio commented May 9, 2017

@pSub fixed. Ready for merge.

@domenkozar domenkozar merged commit b9c0cf9 into NixOS:master May 9, 2017
@dmjio dmjio deleted the ghcjs-fix branch May 9, 2017 07:05
@dmjio
Copy link
Member Author

dmjio commented May 9, 2017

@domenkozar thank you 🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants