python311Packages.{onnxconverter-common,skl2onnx}: unpin protobuf

[aaronjheng]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2696

[FRidh]

Why this change? Has it been tested? If so, on what platform? Please use the form.

[SuperSandro2000]

Those should be 2 commits and one should be a normal update commit

[aaronjheng]

There are errors similar to the following when building these two packages.

...
pythonCatchConflictsPhase
/nix/store/q2zpnf017gccs9w9mb0ikdqhkf0k5v82-catch_conflicts.py:1: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
  import pkg_resources
Found duplicated packages in closure for dependency 'protobuf':
  protobuf 3.20.3 (/nix/store/ybla5hcf1m869cph7c31ydfq1mi7himv-python3.10-protobuf-3.20.3/lib/python3.10/site-packages)
  protobuf 4.24.3 (/nix/store/dr704mj25b1m8xxjkz340jik4grs763g-python3.10-protobuf-4.24.3/lib/python3.10/site-packages)
...

It turns out that they both depend on onnx which depend on protobuf (not protobuf3).

[aaronjheng]

Here's the tricky thing. skl2onnx depends on onnx and onnxconverter-common. And onnxconverter-common also depends on onnx.

[FRidh]

If all parts can work with the latest protobuf, then that is fine. But please be clear about this in your pull request. The form exists for a reason.

[aaronjheng]

If all parts can work with the latest protobuf, then that is fine. But please be clear about this in your pull request. The form exists for a reason.

My bad. All done.

[aaronjheng]

Result of nixpkgs-review pr 256603 run on x86_64-linux 1

12 packages built:

• python310Packages.onnxconverter-common
• python310Packages.onnxconverter-common.dist
• python310Packages.onnxmltools
• python310Packages.onnxmltools.dist
• python310Packages.skl2onnx
• python310Packages.skl2onnx.dist
• python311Packages.onnxconverter-common
• python311Packages.onnxconverter-common.dist
• python311Packages.onnxmltools
• python311Packages.onnxmltools.dist
• python311Packages.skl2onnx
• python311Packages.skl2onnx.dist