Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgadmin4: 7.5 -> 7.7 #257119

Merged
merged 2 commits into from
Oct 20, 2023
Merged

pgadmin4: 7.5 -> 7.7 #257119

merged 2 commits into from
Oct 20, 2023

Conversation

gador
Copy link
Contributor

@gador gador commented Sep 24, 2023

Description of changes

Update of pgadmin4. Changelog: https://www.pgadmin.org/docs/pgadmin4/latest/release_notes_7_7.html

Includes a security fix: CVE-2023-5002

This PR includes the update from pgadmin 7.5 -> 7.6 (see #251936 for an in depth description)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2691

pkgs/tools/admin/pgadmin/default.nix Outdated Show resolved Hide resolved
Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
@gador
Copy link
Contributor Author

gador commented Sep 28, 2023

@SuperSandro2000 done 👍

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1147

@LeSuisse LeSuisse changed the title Pgadmin 7.7 pgadmin4: 7.5 -> 7.7 Oct 14, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1175

@yayayayaka
Copy link
Member

Result of nixpkgs-review pr 257119 run on x86_64-linux 1

4 packages built:
  • pgadmin4
  • pgadmin4-desktopmode
  • pgadmin4-desktopmode.dist
  • pgadmin4.dist

Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though pgadmin 7.8 has been released yesterday, I am going to merge this anyway to get the security fix in.

@yayayayaka yayayayaka merged commit be90db7 into NixOS:master Oct 20, 2023
25 checks passed
@gador
Copy link
Contributor Author

gador commented Oct 20, 2023

@yayayayaka thanks. I'll check out 7.8 in a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants