-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zutty: init at 0.14 #257156
base: master
Are you sure you want to change the base?
zutty: init at 0.14 #257156
Conversation
Squash commits. |
Squashed! Thanks. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2707 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the default.nix file to by-name/zu/zutty/package.nix
Made the suggested changes. Thanks for teaching me about the new by-name/zu/zutty/package.nix approach. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2724 |
postPatch = '' | ||
substituteInPlace src/options.h \ | ||
--replace /usr/share/fonts ${ucs-fonts}/share/fonts | ||
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably add a isNixOS ? true
and set the path to /run/current-system/sw/share/X11/fonts
accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we set the font path to /run/current-system/sw/share/X11/fonts, isn't there a risk that the ucs-fonts won't be installed, and zutty will fail to start as it can't find it's default font (9x18)?
I'm really not sure the right way to package zutty here. Perhaps make it so you can configure both the default font and the font path?
Description of changes
https://tomscii.sig7.se/zutty/
https://github.com/tomscii/zutty
Issue: Hard coding fontpath to ucs-fonts
Note: I've set the fonts directory to be ucs-fonts--the fonts that Zutty was designed for. Zutty does not support searching for fonts using fontconfig and the author has rejected suggestions to support nix/guix or fontconfig instead scanning a hard coded fonts path, or relying on Xresources or command line options. An alternative approach would be to have override-able options for setting the font package and font name. I welcome other suggestions or advice.
From the zutty's author:
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)