prefetch-yarn-deps: Fix handling of scoped packages

[lorenzleutgeb]

Description of changes

I ran into an issue with a lockfile entry of the form "@org/somepack@file:vendor/orgpacks/somepack/assets". fetch-yarn-deps would crash, because it would not detect @file:... and just blindly access pkg.resolved, which was not present.

Things done

Diagnosed and fixed the bug, added a test to avoid regressions in the future.

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[lorenzleutgeb]

@ofborg build gitmoji-cli marp

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2716

[lorenzleutgeb]

@lilyinstarlight maybe this is worth your attention before 23.11 branch-off.

[lilyinstarlight]

@ofborg eval
@ofborg build prefetch-yarn-deps prefetch-yarn-deps.tests

Requesting a fresh eval and also fetcher test build, since this eval is a bit stale and because the commit message uses fetch-yarn-deps instead of prefetch-yarn-deps, ofborg doesn't build the tests

[lilyinstarlight]

The diff itself looks fine to me and does not appear to be a breaking change, so if ofborg builds pass and @yu-re-ka has no objections, I think this looks fine to merge

Thank you!

[lilyinstarlight]

Ofborg failed because fetcher should probably set SSL_CERT_FILE like the others, now that #257513 was merged and Node.js no longer uses the built-in ones... (and this probably means all yarn fetchers are failing/unreproducible FODs right now...)

I'll open a separate PR to fix that since it is orthogonal to this PR

[lilyinstarlight]

I've opened #269061 to fix the fetcher failures

[lorenzleutgeb]

@ofborg eval
@ofborg build prefetch-yarn-deps prefetch-yarn-deps.tests

[...] because the commit message uses fetch-yarn-deps instead of prefetch-yarn-deps, ofborg doesn't build the tests

Fixed.

[github-actions]

Successfully created backport PR for release-23.11:

• [Backport release-23.11] prefetch-yarn-deps: Fix handling of scoped packages #270276