Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vocabsieve: init at 0.11.0 #257444

Closed
wants to merge 2 commits into from
Closed

vocabsieve: init at 0.11.0 #257444

wants to merge 2 commits into from

Conversation

paveloom
Copy link
Member

@paveloom paveloom commented Sep 26, 2023

Description of changes

https://github.com/FreeLanguageTools/vocabsieve

Depends on:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@paveloom paveloom changed the title vocabsieve: init at 0.10.2 vocabsieve: init at 0.11.0 Dec 29, 2023
@RasmusRendal RasmusRendal mentioned this pull request Jan 7, 2024
13 tasks
@RasmusRendal
Copy link
Contributor

It's missing the QT audio plugins, so it can't play the pronunciation clips. Feel free to steal some nix code from #279361

@paveloom
Copy link
Member Author

pyqtgraph is broken on master at the moment because of #217275.

@paveloom paveloom closed this Jan 29, 2024
@paveloom paveloom deleted the vocabsieve branch January 29, 2024 14:22
@eljamm
Copy link
Contributor

eljamm commented Apr 30, 2024

I tried this PR against the latest master branch, but I get an error that there are no qt plugins. However, #279361 worked for me, including the audio and I managed to create Anki cards using it.

If there are no issues anymore, is there a chance to re-open this? I'd be awesome if this got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants