rss-bridge: 2022-06-14 -> 2023-09-24 #257641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
Comment on lines
15
to
20
| substituteInPlace lib/RssBridge.php \ | ||
| --replace "__DIR__ . '/../config.ini.php'" "getenv('RSSBRIDGE_DATA') . '/config.ini.php'" | ||
| substituteInPlace lib/bootstrap.php \ | ||
| --replace "const PATH_CACHE = __DIR__ . '/../cache/';" "define('PATH_CACHE', getenv('RSSBRIDGE_DATA') . '/cache/');" | ||
| substituteInPlace lib/Configuration.php \ | ||
| --replace "__DIR__ . '/../whitelist.txt'" "getenv('RSSBRIDGE_DATA') . '/whitelist.txt'" |
There was a problem hiding this comment.
Can we use the patch from https://github.com/NixOS/nixpkgs/pull/223066/files instead?
12 tasks
The source code substitutions have to be adopted to continue working. The PATH_CACHE const has to use `define` instead, as const forbids using functions.
Mynacol
force-pushed
the
rss-bridge-23-09
branch
from
7899087
to
56ac715
Compare
|
I moved the changes into a patch file. The referenced PR was not applicable.
|
SuperSandro2000
approved these changes
Oct 17, 2023
|
It seems I can't merge this PR. Can one of you guys do it? |
|
@Mynacol i think you need to add yourself in maintainers/maintainer-list.nix if not already there. And afterwards in meta.maintainers for the package. |
|
I added myself as a maintainer for this package in a second commit. I hope you all are fine with this. |
yayayayaka
pushed a commit
that referenced
this pull request
Oct 22, 2023
As requested in #257641 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update to the latest release: https://github.com/RSS-Bridge/rss-bridge/releases/tag/2023-09-24
The source code substitutions have to be adopted to continue working. The PATH_CACHE const has to use
defineinstead, as const forbids using functions.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)@dawidsowa