Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.apron: don’t strip libraries on darwin #257801

Merged
merged 1 commit into from
Sep 28, 2023
Merged

ocamlPackages.apron: don’t strip libraries on darwin #257801

merged 1 commit into from
Sep 28, 2023

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 28, 2023

See antoinemine/apron#93

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 28, 2023
@vbgl
Copy link
Contributor Author

vbgl commented Sep 28, 2023

@GrahamcOfBorg build framac

@vbgl vbgl merged commit 3dfaa2a into NixOS:master Sep 28, 2023
25 of 26 checks passed
@vbgl vbgl deleted the ocaml-apron-darwin-fix branch September 28, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulrikstrid ulrikstrid Awaiting requested review from ulrikstrid ulrikstrid is a code owner

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: ocaml 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vbgl