Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtile: add iwlib as dependency for wlan widget #258510

Merged
merged 2 commits into from Oct 4, 2023

Conversation

Infinidoge
Copy link
Contributor

Description of changes

iwlib is required for the built-in wlan widget, so added it as a build input to satisfy that.

Additionally, I sorted the built inputs in the derivation, as they were in a random order while the inputs at the top were sorted.
I can remove that commit if wanted, but I personally feel like it would be good to keep.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

While the build inputs as brought in at the top are sorted, the ones
listed in the derivation were not, so sorted them
This is used for the wlan widget
Copy link
Contributor

@arjan-s arjan-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wegank wegank merged commit bc9696a into NixOS:master Oct 4, 2023
26 checks passed
@Infinidoge Infinidoge deleted the fix/qtile-wlan-dependency branch October 4, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants