Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten docs: reword and remove mention of nix-env #258595

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

fricklerhandwerk
Copy link
Contributor

Adding @RaitoBezarius and @matthewbauer to CODEOWNERS to keep track of changes.

really this stuff should move into the source and out of the manual, an effort recently started by @infinisil. but that would require a much larger change touching code, and we didn't want to get into that right now.

@RaitoBezarius
Copy link
Member

Please remove @matthewbauer as I believe they are not that active anymore in nixpkgs maintenance. I recently removed their CODEOWNER entry for other stuff.

@infinisil
Copy link
Member

really this stuff should move into the source and out of the manual

Taking a quick look, all of this looks like user-level documentation, so it should stay in the manual. Only contributor docs should be in the source code.

also notify on documentation changes
in particular, remove mention of `nix-env`

Co-authored by: Henrik Karlsson <i97henka@gmail.com>
that way the examples will also appear in the appendix

Co-authored by: Henrik Karlsson <i97henka@gmail.com>
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-10-05-documentation-team-meeting-notes-84/33877/1

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-10-05-documentation-team-meeting-notes-84/33877/3

@fricklerhandwerk
Copy link
Contributor Author

@RaitoBezarius please recheck.

Copy link
Member

@RaitoBezarius RaitoBezarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fricklerhandwerk fricklerhandwerk merged commit 643419f into NixOS:master Oct 26, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants