-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emscripten docs: reword and remove mention of nix-env
#258595
Emscripten docs: reword and remove mention of nix-env
#258595
Conversation
f741e13
to
43cbe9d
Compare
Please remove @matthewbauer as I believe they are not that active anymore in nixpkgs maintenance. I recently removed their CODEOWNER entry for other stuff. |
Taking a quick look, all of this looks like user-level documentation, so it should stay in the manual. Only contributor docs should be in the source code. |
also notify on documentation changes
in particular, remove mention of `nix-env` Co-authored by: Henrik Karlsson <i97henka@gmail.com>
that way the examples will also appear in the appendix Co-authored by: Henrik Karlsson <i97henka@gmail.com>
43cbe9d
to
b2f5265
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-10-05-documentation-team-meeting-notes-84/33877/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-10-05-documentation-team-meeting-notes-84/33877/3 |
@RaitoBezarius please recheck. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding @RaitoBezarius and @matthewbauer to CODEOWNERS to keep track of changes.
really this stuff should move into the source and out of the manual, an effort recently started by @infinisil. but that would require a much larger change touching code, and we didn't want to get into that right now.