llvmPackages_17: init #258614
llvmPackages_17: init #258614
Conversation
ofborg
bot
requested review from
rrbutani,
dtzWill,
lovek323,
sternenseemann,
alyssais,
RaitoBezarius,
primeos and
Ericson2314
RossComputerGuy
force-pushed
the
feat/llvm-17
branch
from
8250db5
to
8a79586
Compare
|
So far, this is what I've gotten. Anything that isn't mentioned with an error is because I wasn't able to compile due to a dependency error. Builds & Works
Broken
libunwindlldbTried using the git version of the resource patch, failed to apply so the patch may need to be updated. |
|
Just a note to say, please make sure llvmPackages_git is kept in sync with the new LLVM 17 package. Last time this wasn't done and it was a huge headache afterwards. |
|
Alright, I'll update it once llvm 17 fully builds. @RaitoBezarius brought that up as well. |
|
Anything I can do to help you with this? I work on LLVM (flang mostly) and use NixOS so would love to have this working! |
|
I've been testing this out and getting it working on my Apple M1 Pro NixOS Asahi machine actually. Right now, I might need help finding or making certain patches that can get things working. I can make a separate commit after the init commit is done to add new things, already got word from someone else who's interested in having MLIR. |
|
Yeah I wasn't suggesting we do everything at once just that MLIR and flang would be nice to have :) |
|
FWIW I had a quick look and the libunwind issue isn't actually to do with libunwind; I can't use the clang built from this to build a C file that includes <stddef.h> either. I guess the wrapper isn't setting some of the include locations correctly? |
|
Could be related to the gun install dirs patches? I removed them since patch didn't like them. Would have to update the patches. |
|
That does sound like something that would affect it. This wouldn't help LLVM17 as that's already released but as a more general point, I wonder if we could get some of the patches that are carried by NixOS into LLVM itself so we don't face the issue of having to update them all the time? I'm not really familiar with what the patches that NixOS carries do but LLVM is generally happy to have some linux distribution specific stuff if it's necessary (there's some Gentoo specific stuff for example) |
|
Yeah, I agree. I think we should push for upstream patches that makes it easier for us to package new LLVM versions. It would be a much better long term solution for packaging and would make it easier. |
RossComputerGuy
force-pushed
the
feat/llvm-17
branch
from
8a79586
to
1f23836
Compare
|
I've fixed a few things, got clang working and libunwind builds now! Clang is working since I rebased the gnu install dirs patch. I'll look into rebasing the other gnu install dirs patches which should make everything working. But now I should be able to try this out with Zig compiler development now since the essentials build. Builds & Works
Broken
|
AIUI @Ericson2314 has been in the process of upstreaming our LLVM patches for a long time, but progress has been slow. |
|
I’m happy to help review on the LLVM side if there are patches going up :) |
|
I have commit bit actually (unless they removed it for me being inactive) I have just been slow / doing other things. Feel free to stalk me on phabricator and see what things are still open. |
|
The |
RossComputerGuy
force-pushed
the
feat/llvm-17
branch
from
1f23836
to
2a4b681
Compare
|
@wegank I can boot into macOS on my MBP instead of NixOS and test it on aarch64-darwin. I don't have x86_64-darwin though. |
|
Result of 2 packages failed to build:
35 packages built:
|
|
Result of 18 packages failed to build:
19 packages built:
|
|
x86_64-darwin builds hit llvm/llvm-project#64226, which isn't surprising since |
|
If we absolutely have to do it, we can revert the change to require 10.13 and hope nothing breaks. Alternatively, once a major package needs LLVM 17 (like Rust or Chromium will eventually), build libcxxabi and compiler-rt with the 11.0 SDK until @toonn’s SDK update is ready. |
What's the best way to perform the check? |
RossComputerGuy
force-pushed
the
feat/llvm-17
branch
from
9a370ad
to
d6d5c8a
Compare
|
Result of 38 packages built:
|
|
Result of 43 packages built:
|
|
Result of 24 packages marked as broken and skipped:
21 packages built:
|
|
@ofborg build llvmPackages_17.clang llvmPackages_17.clang.passthru.tests |
|
Successfully created backport PR for |
rrbutani
added
the
6.topic: llvm/clang
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-258614-to-release-23.11 origin/release-23.11
cd .worktree/backport-258614-to-release-23.11
git switch --create backport-258614-to-release-23.11
git cherry-pick -x d6d5c8a14e326588aca3b86dafc9aa7c6c26c09a |
Description of changes
Adds llvm v17, fixes #257654. Will be opened as a draft as work is being done.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)