appimageTools: add libmpg123 to the environment

[michaelBelsanti]

Description of changes

Added libmpg123 to environment for appimages. This is to fix the Slippi Online appimage that comes with the Slippi Launcher and currently fails to run with undefined symbol: mpg123_info2.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[bjornfor]

Does AppImage documentation say anything about what should be provided by the appimage and what should be provided by the host OS? (Why couldn't/shouldn't Slippi Launcher bundle libmpeg123?)

[michaelBelsanti]

I must have misread it yesterday, I believed mpg123 was part of the list, but it is not. Since this file contains a section for packages that are not explicitly mentioned, but are required by one or more appimages, I think it could be included. However, I will first open an issue in the relevant slippi repo to see if it can be added there.

[michaelBelsanti]

There hasn't been much interest in the issue I opened on Slippi's gh, and I do not have the knowledge of appimage packaging needed to fix their build, I think this should be merged. There's already a small list of packages that are not in the list, but are expected by at least one app.

[evils]

i'm unfamiliar with slippi, their launcher appimage seems to work without issue for me
you refer to a slippi online appimage, and slippi-netplay, i could not find such appimages

[michaelBelsanti]

After running the slippi launcher appimage, did you try to launch slippi? It does this by launching the slippi-netplay appimage, which can also be found in ~/.config/Slippi iirc. This appimage fails to launch when run.

[evils]

i skipped making an account, play offline results in "No Melee ISO file specified" i don't have such a file
appimage-run ~/.config/Slippi\ Launcher/netplay/Slippi_Online-x86_64.AppImage indeed fails with libsndfile.so.1: undefined symbol: mpg123_info2

and this change indeed fixes that

[michaelBelsanti]

Yeah my bad, I forgot to mention I used the snippet from this wiki page to make it possible for the launcher to execute the appimages.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3371

[SuperSandro2000]

I am a bit worried that this list will get longer and longer. Do we have any good alternatives available?