buildGoModule: deprecate vendorSha256 attribute #259999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
aaronjheng
force-pushed
the
go
branch
2 times, most recently
from
f049947
to
c301c2e
Compare
wegank
reviewed
Oct 10, 2023
|
Is the plan to fully drop it after a release or two? |
|
As far as I know, no. |
This was referenced Oct 12, 2023
Mic92
approved these changes
Nov 5, 2023
wegank
approved these changes
Nov 14, 2023
13 tasks
This was referenced Jan 26, 2024
carletes
reviewed
Jan 31, 2024
| @@ -297,6 +297,7 @@ let | |||
| } // meta; | |||
| }); | |||
| in | |||
| lib.warnIf (args' ? vendorSha256) "`vendorSha256` is deprecated. Use `vendorHash` instead" | |||
There was a problem hiding this comment.
Are we not missing a third argument to warnIf, as its docstring says? After I've updated nixpkgs in the flake definition where I keep my NixOS configuration, I get an error whenever I run nixos-rebuild switch --flake . --show-trace:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)