Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minisat: fix maintainer #26011

Merged
merged 2 commits into from
May 23, 2017
Merged

minisat: fix maintainer #26011

merged 2 commits into from
May 23, 2017

Conversation

disassembler
Copy link
Member

Motivation for this change

Travis builds are breaking because maintainer string is wrong.

$ ./maintainers/scripts/travis-nox-review-pr.sh nixpkgs-verify nixpkgs-manual nixpkgs-tarball nixpkgs-unstable
=== Verifying that nixpkgs evaluates...
error: undefined variable ‘Mic92’ at /home/travis/build/NixOS/nixpkgs/pkgs/applications/science/logic/minisat/unstable.nix:18:39
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@disassembler
Copy link
Member Author

Also found same problem in buildbot. Added commit to fix it as well.

@Mic92 Mic92 merged commit 51930ce into NixOS:master May 23, 2017
@Mic92
Copy link
Member

Mic92 commented May 23, 2017

Thanks!

@Mic92
Copy link
Member

Mic92 commented May 23, 2017

Maybe I should capitalize it in maintainers.nix. (:

@disassembler disassembler deleted the minisat-unstable branch May 23, 2017 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants