Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autotrace: init at 0.31.1 #26026

Merged
merged 2 commits into from
Jun 30, 2017
Merged

autotrace: init at 0.31.1 #26026

merged 2 commits into from
Jun 30, 2017

Conversation

Hodapp87
Copy link
Contributor

Motivation for this change

autotrace isn't in nixpkgs, and the process of building it is a bit weird due to the package being fairly old.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Add ApplicationServices for Darwin build

Clean up comments
@bennofs
Copy link
Contributor

bennofs commented Jun 30, 2017

Thanks! I fixed the pstoedit issue (this was just because it is based on an autodated pstoedit. Additionally, we had a bug in our pstoedit packaging fixed in 3ab2808).

I have no idea why it depends on libpng16 though.

@bennofs bennofs merged commit 58a231d into NixOS:master Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants