Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grub module: Add support for scaleable menu fonts #26227

Merged
merged 1 commit into from
Jun 10, 2017

Conversation

benley
Copy link
Member

@benley benley commented May 30, 2017

Motivation for this change

The default grub font is too small to be legible on some hidpi displays. This makes it possible to specify a TrueType or OpenType font at any point size, and it will automatically be converted to the format the Grub uses. If font is left blank, the default is to continue using the normal grub default as before.

The default font is unreadably small on some hidpi displays. This
makes it possible to specify a TrueType or OpenType font at any point
size, and it will automatically be converted to the format the Grub
uses.
@mention-bot
Copy link

@benley, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @wkennington and @obadz to be potential reviewers.

@benley benley changed the title nixos: Add support for scalable fonts in Grub menus grub module: Add support for scaleable menu fonts Jun 3, 2017
@benley benley requested a review from wkennington June 3, 2017 17:02
@benley
Copy link
Member Author

benley commented Jun 8, 2017

If there are no objections I'm going to merge this in a day or two.

@fpletz fpletz self-requested a review June 10, 2017 10:33
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm here! Thanks!

Tested with:

boot.loader.grub.font = "${pkgs.hack-font}/share/fonts/hack/Hack-Regular.ttf";
boot.loader.grub.fontSize = 32;

@benley benley merged commit 700e22f into NixOS:master Jun 10, 2017
@benley benley deleted the grub-fonts branch June 10, 2017 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants