nodejs: init at 8.0.0 #26262
Merged
nodejs: init at 8.0.0 #26262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puffnfresh
approved these changes
May 31, 2017
puffnfresh
reviewed
May 31, 2017
| sha256 = "072g2zv58aa5zxs8fs9bdsi3mqklf2yj9mf58yjg5frbcfikm395"; | ||
| }; | ||
|
|
||
| patches = stdenv.lib.optionals stdenv.isDarwin [ ./no-xcode-v7.patch ]; |
There was a problem hiding this comment.
This patch still apply?
There was a problem hiding this comment.
Yes, the patch was updated recently in #25539.
There was a problem hiding this comment.
Since node v 7.10.0 we need to apply the no-xcode-v7.patch file, for older versions we have to use no-xcode.patch.
|
I can confirm that the build works on OS X Sierra ( |
|
Shouldn't this include a Other than that, looks good for merge to me |
|
@wmertens currently there are no packages build with nodejs 8. So I would do this once it is needed. We also don’t have a |
|
Ok, let's merge this then :)
…On Thu, Jun 1, 2017, 12:19 PM Mathias Schreck ***@***.***> wrote:
@wmertens <https://github.com/wmertens> currently there are no packages
build with nodejs 8. So I would do this once it is needed. We also don’t
have a nodePackages_7_x.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26262 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADWluil4YpPHETiiLW1hrjW9epd-qUfks5r_pAVgaJpZM4Nq4JH>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Nodejs has just been released with a new major version which will become the next LTS version later this year.
Also the bundled
npmversion was updated to v5.0.0 which comes with new lockfile format.Release Notes nodejs
Release Notes npm
Things done
nix-shell -p nox --run "nox-review wip"./result/bin/)