New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quarto: 1.3.450 -> 1.4.550 #263108
quarto: 1.3.450 -> 1.4.550 #263108
Conversation
Looks like it needs more work: the package builds and installs, but running
|
This looks like an upstream bug. From a quick look, this was probably introduced here: quarto-dev/quarto-cli#6182 On x86_64-linux, the But this moved the override variable from Do you want to open an issue? |
Done! |
So we got some input from the Quarto devs already. Could we solve this on our end? Maybe by adapting something in the preFixup phase? BTW, I take advantage of this (sorry, I don’t know how else to reach you) to tell you about a matrix room focused on R users on NixOS, I don’t know if you heard about it: https://matrix.to/#/#r:nixos.org |
This should address the issue #7344 raised in NixOS/nixpkgs#263108 Thanks to @b-rodrigues and @minijackson for their diligence in identifying the issue.
This should address the issue #7344 raised in NixOS/nixpkgs#263108 Thanks to @b-rodrigues and @minijackson for their diligence in identifying the issue.
So quarto-dev/quarto-cli@d90a385 solves the issue,
|
Everything still ok on version 1.4.531-prerelease. Question: once the new version actually gets released (beginning of next year, from what I’ve heard), should I open a new pull request or squash all the commets and simply change the status of this one? |
Squashing all the commits, and changing the PR title seems fine for me! |
Hello @b-rodrigues, I've been using I am still trying to learn how to use NixOS so I hope that you don't mind me posting this question here. Basically, I'm wondering if you can give me an example of how to use the source code connected to this PR to see if I can get |
Hi @gkapfham I would suggest we take this to the nixpkgs-R matrix channel: https://matrix.to/#/#r:nixos.org there's many experienced people there that might also help :) |
Hi, I was wondering: how can we support Typst, through the environment var "QUARTO_TYPST" for instance? |
Everything seems to be working well with the 1.4 release, also added support for typst, thanks @camillemndn for nudging me! Just running |
Great! I use it with |
6ef4253
to
3e345f6
Compare
Everything working well on my end: tested on an hello world qmd with R and Python chunks, also tested on a typst hello world. Squashed the commits into 1 as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Played around for quite a bit, everything works well!
Thanks a lot ❤️
Result of nixpkgs-review pr 263108
run on x86_64-linux 1
2 packages marked as broken and skipped:
- python312Packages.nbdev
- python312Packages.nbdev.dist
8 packages built:
- python311Packages.nbdev
- python311Packages.nbdev.dist
- quarto
- quartoMinimal
- rstudio
- rstudio-server
- rstudioServerWrapper
- rstudioWrapper
Is the patch file really necessary? The
|
Hi, I don’t have strong opinions on this. I’ll let @minijackson @camillemndn and @MrTarantoga decide if we should get rid of the patch? |
I have a slight preference for removing the patch, so that all the fixup happens in |
a76b0e6
to
5b0dcc7
Compare
Ok, so I've incorporated @ogoid 's changes as well, and tested it everything seems to be working fine. Also squashed all the commits into one 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot!
Result of nixpkgs-review pr 263108
run on x86_64-linux 1
2 packages marked as broken and skipped:
- python312Packages.nbdev
- python312Packages.nbdev.dist
8 packages built:
- python311Packages.nbdev
- python311Packages.nbdev.dist
- quarto
- quartoMinimal
- rstudio
- rstudio-server
- rstudioServerWrapper
- rstudioWrapper
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1457 |
Hi,
Many thanks for taking care of Quarto ! |
hey thanks for the heads-up! I'll update this PR to reflect this new release tomorrow |
c86dc2e
to
3223dea
Compare
Updated to latest quarto, everything should be working fine still. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
Result of nixpkgs-review pr 263108
run on x86_64-linux 1
2 packages marked as broken and skipped:
- python312Packages.nbdev
- python312Packages.nbdev.dist
8 packages built:
- python311Packages.nbdev
- python311Packages.nbdev.dist
- quarto
- quartoMinimal
- rstudio
- rstudio-server
- rstudioServerWrapper
- rstudioWrapper
3223dea
to
27b830f
Compare
Thanks for the inputs, everything seems to be working still 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 263108
run on x86_64-linux 1
10 packages built:
- python311Packages.nbdev
- python311Packages.nbdev.dist
- python312Packages.nbdev
- python312Packages.nbdev.dist
- quarto
- quartoMinimal
- rstudio
- rstudio-server
- rstudioServerWrapper
- rstudioWrapper
Description of changes
Updated to release 1.4.550.
Added support for typst.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)