Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llm-ls: init at 0.4.0 #263320

Merged
merged 1 commit into from
Nov 6, 2023
Merged

llm-ls: init at 0.4.0 #263320

merged 1 commit into from
Nov 6, 2023

Conversation

jfvillablanca
Copy link
Member

@jfvillablanca jfvillablanca commented Oct 25, 2023

Description of changes

Resolves #263181

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@jfvillablanca
Copy link
Member Author

Result of nixpkgs-review pr 263320 run on x86_64-linux 1

1 package built:
  • llm-ls

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2830

@teto teto self-requested a review November 2, 2023 00:00
@teto
Copy link
Member

teto commented Nov 5, 2023

thanks for the package: I was able to test it successfully with https://github.com/huggingface/llm.nvim. Seems like it breaks on darwin so maybe make it available only for linux ? Also the file could be moved to pkgs/by-name as recommended at https://github.com/NixOS/nixpkgs/tree/master/pkgs/by-name#readme

@jfvillablanca
Copy link
Member Author

thanks for the package: I was able to test it successfully with https://github.com/huggingface/llm.nvim. Seems like it breaks on darwin so maybe make it available only for linux ? Also the file could be moved to pkgs/by-name as recommended at https://github.com/NixOS/nixpkgs/tree/master/pkgs/by-name#readme

initially, i set it like this

platforms = with platforms; [ linux ];

then, per recommendation from the docs, i changed it to:

platforms = with platforms; [ all ];
badPlatforms = with platforms; [ darwin ];

however, i'm having trouble making nix build with either one because this is what nix detects as my platform:
hostPlatform.config = "x86_64-unknown-linux-gnu"
which isn't part of the list of targets

What am I missing here?

@adisbladis
Copy link
Member

Platforms are already in list form:

platforms = with platforms; [ all ];
badPlatforms = with platforms; [ darwin ];

->

platforms = platforms.all;
badPlatforms = platforms.darwin;

@jfvillablanca
Copy link
Member Author

Platforms are already in list form:

platforms = with platforms; [ all ];
badPlatforms = with platforms; [ darwin ];

->

platforms = platforms.all;
badPlatforms = platforms.darwin;

Thanks! 😅

@teto teto merged commit ba774d3 into NixOS:master Nov 6, 2023
22 of 23 checks passed
@jfvillablanca jfvillablanca deleted the llm-ls branch November 6, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: llm-ls
4 participants