clifm 1.14.6 -> 1.15

[nadir-ishiguro]

changelog: https://github.com/leo-arch/clifm/releases/tag/v1.15

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2853

[pbsds]

Please reword the commit to start with clifm:, otherwise ofborg doesn't understand it. :)

Also the shebangs in $out/share/clifm/tools/ don't work on nixos, consider patching #!/usr/bin/python3 to #!/usr/bin/env python3

[nadir-ishiguro]

Please reword the commit to start with clifm:, otherwise ofborg doesn't understand it. :)

Also the shebangs in $out/share/clifm/tools/ don't work on nixos, consider patching #!/usr/bin/python3 to #!/usr/bin/env python3

I changed the commit message. Thank you for pointing that out. I have no idea how to patch the python shebang though. Would be grateful for any help with that.

[ghost]

Please reword the commit to start with clifm:, otherwise ofborg doesn't understand it. :)
Also the shebangs in $out/share/clifm/tools/ don't work on nixos, consider patching #!/usr/bin/python3 to #!/usr/bin/env python3

I changed the commit message. Thank you for pointing that out. I have no idea how to patch the python shebang though. Would be grateful for any help with that.

not sure what the OP has in mind but adding python3 to the args and buildInputs will enable patchShebangs to work. though if those scripts are run for the build -- the python ones look like they are related to manpages -- might need to add

  postPatch = ''
    patchShebangs misc/tools
  ''; 

[nadir-ishiguro]

Please reword the commit to start with clifm:, otherwise ofborg doesn't understand it. :)
Also the shebangs in $out/share/clifm/tools/ don't work on nixos, consider patching #!/usr/bin/python3 to #!/usr/bin/env python3

I changed the commit message. Thank you for pointing that out. I have no idea how to patch the python shebang though. Would be grateful for any help with that.

not sure what the OP has in mind but adding python3 to the args and buildInputs will enable patchShebangs to work. though if those scripts are run for the build -- the python ones look like they are related to manpages -- might need to add

  postPatch = ''
    patchShebangs misc/tools
  ''; 

Thank you. I was playing around with patchShebangs, but missed that I had to add python3 to buildInputs and args. After I did that, I checked if manually invoking patchShebangs was necessary at all and it's not. Everything gets automatically patched without manually specifying the python scripts.

Seems like things are working fine now.

[pbsds]

I'm traveling atm and won't be able to test this for a few days, but if none get to this by Wednesday I'll have a look. Diff lgtm!

[pbsds]

Found WIFI, LGTM

Result of nixpkgs-review pr 263659 run on x86_64-linux 1

1 package built:

• clifm