-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cadzinho: init at 0.4.1 #264056
cadzinho: init at 0.4.1 #264056
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2833 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cadzinho vendors SQLite 3.38.2. Perhaups it should be replaced with the nixpkgs package (we usually try to avoid vendored dependencies, but I'm not sure about SQLite specifically).
/usr/share/fonts
is referenced in src/util.c
: https://github.com/zecruel/CadZinho/blob/ee287d0c99c17b8f9e8527570989e6c0c0b79f55/src/util.c#L585-L609
That will not work on NixOS. Not sure how important this is for the application.
It vendors just 2 files ( |
With default fonts on NixOS I see no issues, maybe it's actual for custom fonts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Program seems to work fine.
Result of nixpkgs-review pr 264056
run on x86_64-linux 1
1 package built:
- cadzinho
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1352 |
Description of changes
CadZinho - Minimalist computer aided design (CAD) software.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)