Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cadzinho: init at 0.4.1 #264056

Merged
merged 1 commit into from
Feb 6, 2024
Merged

cadzinho: init at 0.4.1 #264056

merged 1 commit into from
Feb 6, 2024

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Oct 28, 2023

Description of changes

CadZinho - Minimalist computer aided design (CAD) software.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2833

Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cadzinho vendors SQLite 3.38.2. Perhaups it should be replaced with the nixpkgs package (we usually try to avoid vendored dependencies, but I'm not sure about SQLite specifically).

/usr/share/fonts is referenced in src/util.c: https://github.com/zecruel/CadZinho/blob/ee287d0c99c17b8f9e8527570989e6c0c0b79f55/src/util.c#L585-L609
That will not work on NixOS. Not sure how important this is for the application.

@sikmir
Copy link
Member Author

sikmir commented Nov 13, 2023

Cadzinho vendors SQLite 3.38.2. Perhaups it should be replaced with the nixpkgs package (we usually try to avoid vendored dependencies, but I'm not sure about SQLite specifically).

It vendors just 2 files (src/sqlite3.[hc]), perhaps for some reason, replacing with the nixpkgs package would require some Makefile patching. I think it doesn't make much sense in this case, extra maintenance cost.

@sikmir
Copy link
Member Author

sikmir commented Nov 24, 2023

That will not work on NixOS. Not sure how important this is for the application.

With default fonts on NixOS I see no issues, maybe it's actual for custom fonts.

Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Program seems to work fine.

Result of nixpkgs-review pr 264056 run on x86_64-linux 1

1 package built:
  • cadzinho

@sikmir sikmir changed the title cadzinho: init at 0.4.0 cadzinho: init at 0.4.1 Jan 4, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1352

@sikmir sikmir merged commit fec2bb1 into NixOS:master Feb 6, 2024
23 checks passed
@sikmir sikmir deleted the cadzinho branch February 6, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants