New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/guix: init #264331
nixos/guix: init #264331
Conversation
There are still some setups I have to figure out so it's in draft for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh nice work, can't wait to try this out!
Maybe since you've done most of the work on guix you'd want to add yourself to the maintainers on the guix
package as well?
Sure. That's fine by me.
I'm open for ideas. (I find it amusing both PRs are drafted just within an hour) |
Well my draft intended to open the discussion for the options, but it seems you already have the module ready. |
1d50427
to
5811abe
Compare
I only upstreamed the module from my Guix overlay and haven't updated or gave the module options a second look before this PR so there's still room for discussion. |
a56c2f1
to
ab9144b
Compare
A few test setups later and it is done. Should be ready for review. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2857 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please read through the descriptions and make sure they are written in a style suitable for a manual.
Also please check that the comments explain the reason something is done and don't just elaborately describe the line below with little extra information.
|
Yeah, I neglected checking for the documentation on this one. My bad. Will keep that in mind for future modules. |
Good point. Will update the unit with those.
If you meant managing custom Guix channels, this module does not handle Guix channels. You should be able to handle them as described in the manual. As for the package, it doesn't bundle any channels. |
ab9144b
to
ae1cf8c
Compare
ae1cf8c
to
1a207ff
Compare
This is in preparation for the Nix module where it will allow the user to set custom store and state directory.
1a207ff
to
ad277ea
Compare
Since this is a new module (and some new options for the Guix package that appear to match the previous baked-in values), could this be backported to 23.11? I recently started using your overlay repo (thanks!) and just noticed this PR that barely missed the release (and #246975 did make it). I was planning to switch to stable NixOS now that I can try moving my home environment to Guix. |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-264331-to-release-23.11 origin/release-23.11
cd .worktree/backport-264331-to-release-23.11
git switch --create backport-264331-to-release-23.11
git cherry-pick -x df46b418951994499f8b6c4cc12db65f807ea50f 092aaf841806e8a5fcdfea566bbaae2e25cea069 ad277ea47e17e3073ba61af07284d1dff8d1601e |
This has been backported to 23.11 (#272632). Now, it's a matter of waiting for it to land in Also I didn't know you can backport module additions. Nice. |
Yes, new modules are backwards-compatible changes. Meanwhile, this makes the change in the 24.05 release note obsolete. |
Could you elaborate the meaning of this and what action should be taken for
|
I'd like to drop this line and, if possible, move it to the 23.11 release note. |
Description of changes
Now that #246975 is merged, at least why not make a service module for it. While some parts of the integration test is rendered redundant once the package enables checking (e.g.,
doCheck = true
), I guess it's better than nothing.cc @cafkafk
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)