glaxnimate: 0.5.1 -> 0.5.4 + fix #263731 #264387
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2842 |
|
As for Issue #263731 This PR seems to fix the build failure for my machine |
There was a problem hiding this comment.
LGTM for a squash + merge.
Result of nixpkgs-review pr 264387 run on x86_64-linux 1
1 package built:
- glaxnimate
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1204 |
|
blazingly fast checks |
|
Could someone merge (make sure to squash during the merge) this? I keep receiving new PR trying to do the same thing. |
| # Translation needs to be separately compiled | ||
| # https://gitlab.com/mattbas/glaxnimate/-/issues/648 | ||
| postBuild = '' | ||
| make translations |
There was a problem hiding this comment.
Perhaps you could do this using buildFlags, so it's included in the same make command? That way, all the right flags would be applied. Otherwise, the makeFlags and makeFlagsArray variables would need to be used here.
There was a problem hiding this comment.
Thanks, it's done.
tobiasBora
force-pushed
the
glaxnimate_fix_build
branch
from
390e930
to
e375765
Compare
|
Should be good now (commiter: make sure so squash while merging). |
Description of changes
Fix #263731 and upgrade glaxnimate.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)