-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
menulibre: init at 2.2.3 #264513
menulibre: init at 2.2.3 #264513
Conversation
235c868
to
d35025b
Compare
Result of 2 packages built:
|
d35025b
to
aeb5447
Compare
Result of 2 packages built:
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2850 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase against master and push.
Besides LGTM
aeb5447
to
067521a
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1393 |
067521a
to
63c64ec
Compare
63c64ec
to
efa3491
Compare
Updated the derivation to only use a single call |
efa3491
to
ad7e7cd
Compare
ad7e7cd
to
0fb4434
Compare
Result of 2 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets wait for CI to pass
Description of changes
MenuLibre is an advanced menu editor that provides modern features in a clean, easy-to-use interface.
Homepage: https://bluesabre.org/projects/menulibre
Repo: https://github.com/bluesabre/menulibre
Fixes: #84652
Currently is does not seem to fill all icons for categories correctly, but that also happens in the flatpak version.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)