Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menulibre: init at 2.2.3 #264513

Merged
merged 1 commit into from
Feb 13, 2024
Merged

menulibre: init at 2.2.3 #264513

merged 1 commit into from
Feb 13, 2024

Conversation

lelgenio
Copy link

Description of changes

MenuLibre is an advanced menu editor that provides modern features in a clean, easy-to-use interface.

Homepage: https://bluesabre.org/projects/menulibre
Repo: https://github.com/bluesabre/menulibre

Fixes: #84652

Currently is does not seem to fill all icons for categories correctly, but that also happens in the flatpak version.

image

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@lelgenio lelgenio force-pushed the add-menulibre branch 2 times, most recently from 235c868 to d35025b Compare October 31, 2023 13:00
@lelgenio
Copy link
Author

Result of nixpkgs-review pr 264513 run on x86_64-linux 1

2 packages built:
  • menulibre
  • menulibre.dist

@lelgenio
Copy link
Author

Result of nixpkgs-review pr 264513 run on x86_64-linux 1

2 packages built:
  • menulibre
  • menulibre.dist

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2850

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase against master and push.

Besides LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1393

pkgs/by-name/me/menulibre/package.nix Outdated Show resolved Hide resolved
@lelgenio
Copy link
Author

lelgenio commented Feb 5, 2024

Updated the derivation to only use a single call substituteInPlace on the setup script.
The data_dir still works the same. The .desktop file now only has Exec=menulibre instead of Exec=/nix/store/*/bin/menulibre, which should be fine, right? There's many other packages with .desktop files like this.

@lelgenio
Copy link
Author

Result of nixpkgs-review pr 264513 run on x86_64-linux 1

2 packages built:
  • menulibre
  • menulibre.dist

Copy link
Member

@kirillrdy kirillrdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets wait for CI to pass

@SuperSandro2000 SuperSandro2000 merged commit 9f63330 into NixOS:master Feb 13, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MenuLibre
6 participants