Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anki: 2.1.66 -> 23.10.1 #264796

Merged
merged 1 commit into from
Nov 30, 2023
Merged

anki: 2.1.66 -> 23.10.1 #264796

merged 1 commit into from
Nov 30, 2023

Conversation

paveloom
Copy link
Member

@paveloom paveloom commented Nov 1, 2023

Description of changes

https://github.com/ankitects/anki/releases/tag/23.10
https://github.com/ankitects/anki/releases/tag/23.10.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@a-kenji
Copy link
Contributor

a-kenji commented Nov 1, 2023

Result of nixpkgs-review pr 264796 run on x86_64-linux 1

6 packages built:
  • anki
  • anki.dist
  • anki.doc
  • anki.man
  • mnemosyne
  • mnemosyne.dist

Also tested basic functionality, seems to work well.

@paveloom paveloom changed the title anki: 2.1.66 -> 23.10 anki: 2.1.66 -> 23.10.1 Nov 23, 2023
Copy link
Member

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I verified anki runs and works for me with this.

Thank you!

@a-kenji
Copy link
Contributor

a-kenji commented Nov 23, 2023

Result of nixpkgs-review pr 264796 run on x86_64-linux 1

6 packages built:
  • anki
  • anki.dist
  • anki.doc
  • anki.man
  • mnemosyne
  • mnemosyne.dist

Copy link
Member

@martinetd martinetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-wise LGTM, the updated patch content is identical to what I had for 23.10beta6 a while back.

@wegank wegank merged commit 27ed44c into NixOS:master Nov 30, 2023
22 checks passed
@paveloom paveloom deleted the anki branch November 30, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants