-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devmode: migrate into pkgs/by-name #265259
base: master
Are you sure you want to change the base?
Conversation
This move will also make the tool available outside of nixpkgs codebase.
@@ -114,4 +118,11 @@ | |||
"${lib.getBin server}/bin/server" | |||
''; | |||
in | |||
devmode | |||
devmode // |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps use overrideAttrs here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, no nitpicks from me today.
For one, I never intended it to be public. I didn't want to lock the API. |
I'd agree with @mightyiam here, let's not expose this in |
This move will also make the tool available outside of nixpkgs codebase.