Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devmode: migrate into pkgs/by-name #265259

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alejandrosame
Copy link
Contributor

This move will also make the tool available outside of nixpkgs codebase.

This move will also make the tool available outside of nixpkgs codebase.
@@ -114,4 +118,11 @@
"${lib.getBin server}/bin/server"
'';
in
devmode
devmode //
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps use overrideAttrs here?

Copy link
Contributor

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, no nitpicks from me today.

@mightyiam
Copy link
Member

For one, I never intended it to be public. I didn't want to lock the API.

@infinisil
Copy link
Member

I'd agree with @mightyiam here, let's not expose this in pkgs unless we're certain of its interface. Instead third-party users can still callPackage the path to the package directly (which might break in the future as we should be expecting, generally paths are not a stable interface).

@wegank wegank marked this pull request as draft November 8, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants