Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.python-docs-theme: rename from python_docs_theme #265377

Merged
merged 4 commits into from
Nov 4, 2023

Conversation

natsukium
Copy link
Member

Description of changes

part of #245383

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium
Copy link
Member Author

Result of nixpkgs-review pr 265377 at 56b570d run on x86_64-linux 1

2 packages built successfully:
  • python310Packages.python-docs-theme
  • python311Packages.python-docs-theme

@fabaff
Copy link
Member

fabaff commented Nov 4, 2023

Result of nixpkgs-review pr 265377 run on x86_64-linux 1

4 packages built:
  • python310Packages.python-docs-theme
  • python310Packages.python-docs-theme.dist
  • python311Packages.python-docs-theme
  • python311Packages.python-docs-theme.dist

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit a87a008 into NixOS:master Nov 4, 2023
21 of 22 checks passed
@natsukium natsukium deleted the python-docs-theme branch November 4, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants