Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesa: 23.1.7 -> 23.3.0, bump patches #265740

Closed
wants to merge 1 commit into from

Conversation

colemickens
Copy link
Member

@colemickens colemickens commented Nov 5, 2023

Description of changes

Maybe useful for anyone who wants to test, since we haven't merged #258017 and I don't know what the status of the 23.2 branch is for mesa. There's been no commits to the 23.2 branch since 23.2.1 was cut and released.

EDIT: To be clear, this is left as a draft, and even if it weren't is not meant to be merged as is.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Nov 6, 2023

I don't understand what's happening upstream around 23.2. There's been no activity in the branch for over five weeks now (only staging/23.2) and even 23.1 has newer changes and release than that. No mention in announcements, not even a proper announcement for any non-RC 23.2 version.

For now it seems that we'll keep NixOS 23.11 on mesa-23.1, as I didn't notice anything very important in 23.2 and it didn't feel "stable enough" so far.

@tormeh
Copy link
Contributor

tormeh commented Nov 7, 2023

didn't notice anything very important

Well, according to Phoronix ray tracing is turned on by default on RADV: https://www.phoronix.com/news/Mesa-23.2.1-Released

@vcunat
Copy link
Member

vcunat commented Nov 7, 2023

I think I did see that, but importance is just subjective.

@stereomato
Copy link

it also fixes this https://gitlab.freedesktop.org/mesa/mesa/-/issues/8853

@whazor
Copy link

whazor commented Nov 11, 2023

I am looking forward to AV1 video encoding on AMD graphic cards, which is added on Mesa 23.3: https://www.phoronix.com/news/AMD-Mesa-AV1-VA-API-Encode

@colemickens colemickens force-pushed the mesa-23.3.x branch 2 times, most recently from d57c3f4 to 11591ff Compare November 12, 2023 22:27
@romatthe
Copy link
Contributor

I agree that the inactivity around 23.2 is rather strange (as I was expecting at least a 23.2.2 relatively soon after the first stable 23.2 release), it would be a bit of a shame if we won't be able to land Mesa 23.2 in NixOS 23.11, since that's my only opportunity to get a new mesa release for the next 6 months. While I don't have any specific features from 23.2 that I need, it's always nice to get the general improvements, no matter how small.

I assume that even if Mesa 23.3.0-rc4 (which should release this Wednesday) turns out to be the final release of this series, the window to get it merged for NixOS 23.11 will be too small?

@vcunat
Copy link
Member

vcunat commented Nov 13, 2023

We normally don't even use .0 releases in nixpkgs, so who knows when 23.3.1 comes. And the window for "breaking changes" (which this probably is) was closed already.

@colemickens colemickens force-pushed the mesa-23.3.x branch 2 times, most recently from ea40db6 to 613c356 Compare November 18, 2023 22:53
@vcunat vcunat changed the title mesa: 23.1.7 -> 23.3.0-rc2, bump patches mesa: 23.1.7 -> 23.3.*, bump patches Nov 19, 2023
@colemickens colemickens changed the title mesa: 23.1.7 -> 23.3.*, bump patches mesa: 23.1.7 -> 23.3.0, bump patches Nov 29, 2023
@colemickens
Copy link
Member Author

23.3.0 is out. I've bumped this PR. Leaving as draft until 23.3.1. System is rebuilding, I haven't tested yet.

@jansol
Copy link
Contributor

jansol commented Nov 30, 2023

@colemickens could you add a comment in default.nix describing what the OpenCL patch does? The patch itself isn't very obvious to me. Same for the cache dir patch, since this commit drops the original commit message from the patch file.

@colemickens
Copy link
Member Author

@jansol good feedback, I'll try to re-generate the patches with their messages, and give a short comment in the default.nix. I will do this when I bump to 23.3.1 and mark as ready.

@Kreyren
Copy link
Contributor

Kreyren commented Dec 4, 2023

Heads-up: OLIMEX Teres-A64 has broken mesa in NixOS due to https://gitlab.freedesktop.org/mesa/mesa/-/issues/8198 which results in stuff erroring in DRM_IOCTL_MODE_CREATE_DUMB failed: Cannot allocate memory that eventually crash the system which was fixed in https://gitlab.freedesktop.org/mesa/mesa/-/commit/c426e5677f36c3b0b8e8ea199ed4f2c7fad06d47 which was backported in mesa 22.3, skipping 23.0, and will be in 23.1 as the commit was merged into main before 23.1 branches off of main where backport was not introduced in NixOS.

This update should fix the issues, please make sure that the mentioned patch is included in the update. Thanks ✌️

@Kreyren Kreyren mentioned this pull request Dec 8, 2023
12 tasks
@jansol
Copy link
Contributor

jansol commented Dec 13, 2023

23.3.1 is out!

@K900
Copy link
Contributor

K900 commented Dec 13, 2023

Good. I'll get it tomorrow if @colemickens doesn't.

@K900 K900 mentioned this pull request Dec 14, 2023
13 tasks
@Atemu
Copy link
Member

Atemu commented Dec 15, 2023

#274177

@Atemu Atemu closed this Dec 15, 2023
@colemickens colemickens deleted the mesa-23.3.x branch February 17, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants