Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init haystack #265845

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Init haystack #265845

merged 2 commits into from
Nov 8, 2023

Conversation

happysalada
Copy link
Contributor

@happysalada happysalada commented Nov 6, 2023

Description of changes

This is still a little rough, I'm opening this early for feedback/ help.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

pkgs/development/python-modules/haystack/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/haystack/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/haystack/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/haystack/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@happysalada
Copy link
Contributor Author

@natsukium thank you for the review, I've made the changes.
What I found weird was mostly around the optional dependencies containing the package itself, the rest should hopefully be fine.

@natsukium
Copy link
Member

The excessive aliases might be necessary for development.

@happysalada happysalada merged commit e556bb0 into NixOS:master Nov 8, 2023
22 of 23 checks passed
@happysalada happysalada deleted the init_haystack branch November 8, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants