Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intiface-central: init at 2.5.3 #265961

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

999eagle
Copy link
Contributor

@999eagle 999eagle commented Nov 6, 2023

Description of changes

This PR adds Intiface Central. See https://intiface.com/.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3020

@qbit
Copy link
Contributor

qbit commented Dec 1, 2023

Result of nixpkgs-review pr 265961 run on x86_64-linux 1

1 package built:
  • intiface-central

@qbit
Copy link
Contributor

qbit commented Dec 1, 2023

App seems to run as expected! I am not super familiar with flutter stuff but it looks ok compared to other flutter packages in the tree.. I also don't have any devices to .. erm.. test with. <.<

Copy link
Member

@ajs124 ajs124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work with my Xbox 360 controller (turned on XInput in settings, but I'm on Wayland, so…) but tested successfully with a compatible Bluetooth device.

Don't know how our flutter packaging works, but LGTM.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1289

@Kranzes Kranzes merged commit 729bd74 into NixOS:master Dec 12, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants