persepolis: ZHF: fix build and runtime errors on darwin #266050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/should-i-fix-a-bug-within-nixpkgs-if-upstream-wont/35127/1 |
iFreilicht
force-pushed
the
zhf-fix-persepolis
branch
from
353b5cc
to
94e0701
Compare
pbsds
reviewed
Nov 9, 2023
pkgs/tools/networking/persepolis/0003-Search-PATH-for-aria2c-on-darwin.patch
Outdated
Show resolved
Hide resolved
pkgs/tools/networking/persepolis/0001-Allow-building-on-darwin.patch
Outdated
Show resolved
Hide resolved
iFreilicht
force-pushed
the
zhf-fix-persepolis
branch
from
94e0701
to
e89c0f4
Compare
|
Seems like #266670 got ahead of us. Could you rebase it on top of master an unmark it broken? |
Notifications will be broken until NixOS#105156 is resolved. ZHF: NixOS#265948
The video finder is still broken on youtube, but that's an upstream issue that we might not want to fix ourselves, see persepolisdm/persepolis#930
This fixes the upstream issue persepolisdm/persepolis#930
wegank
force-pushed
the
zhf-fix-persepolis
branch
from
e89c0f4
to
bf62348
Compare
wegank
approved these changes
Nov 10, 2023
|
@ofborg build persepolis persepolis.passthru.tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This fixes the build and runtime errors on darwin as part of #265948.
Things done
youtube-dlwith maintained forkyt-dlpto restore video finder functionality (this was broken on Linux and Darwin)nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)