Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmic-greeter: init at unstable-2023-11-08 #266138

Merged
merged 1 commit into from Nov 9, 2023

Conversation

nyabinary
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@a-kenji
Copy link
Contributor

a-kenji commented Nov 7, 2023

Result of nixpkgs-review pr 266138 run on x86_64-linux 1

1 package built:
  • cosmic-greeter

Copy link
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I left a few minor nits for seemingly unused stuff, but otherwise this looks merge-ready

pkgs/by-name/co/cosmic-greeter/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-greeter/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-greeter/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-greeter/package.nix Outdated Show resolved Hide resolved
@nyabinary nyabinary changed the title cosmic-greeter: init at unstable-2023-10-25 cosmic-greeter: init at unstable-2023-11-08 Nov 9, 2023
Copy link
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks good to me now! Once the ofborg eval+builds all succeed, then I'll go ahead and merge, thanks!

@lilyinstarlight lilyinstarlight merged commit afe1ce6 into NixOS:master Nov 9, 2023
23 of 24 checks passed
@genofire
Copy link
Contributor

genofire commented Jan 2, 2024

How to use it?

the following does not work:

{pkgs, ...}:
{
  services.greetd = {
    enable = true;
    pkgs.cosmic-greeter;
  };
}
``

@nyabinary nyabinary deleted the cosmic-greeter branch January 2, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants